fix: wrapped quote message links in the main box instead of the time box#31892
Closed
Arin13-03 wants to merge 1 commit into
Closed
fix: wrapped quote message links in the main box instead of the time box#31892Arin13-03 wants to merge 1 commit into
Arin13-03 wants to merge 1 commit into
Conversation
|
Member
|
Hi there, thanks for the contribution! 🚀 💯 Closing this PR because it's stale now, we decide to move with this approach #41091 Questions? Help needed? Feature Requests?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…box#31748
Proposed changes (including videos or screenshots)
The problem arose from quote links being enclosed within the time box. I addressed this by removing the message link from there and setting the color to 'hint', which is the default for rendering in both cases. Additionally, I enclosed the message link around the entire component to enhance accessibility. I also set the textDecoration to none. As a result, users can now click directly on the main box and be scrolled to the quoted message.
Issue(s)
Closes #31747
Steps to test or reproduce
Further comments
NA